o/snapstate: set UserID for download-component task - #17020
Merged
Mohit-Chachada merged 1 commit intoMay 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses LP2110368 by ensuring component downloads can use user authentication when required (e.g., for private snaps). It does so by propagating an appropriate UserID into the SnapSetup used by component-related tasks, and adds tests to verify authenticated vs unauthenticated download behavior and the precedence rules for selecting the user ID.
Changes:
- Set
SnapSetup.UserIDduringInstallComponentsusing existinguserIDForSnap(...)selection logic (snap state user ID preferred, otherwise install opts). - Add a new unit test covering
download-componentbehavior when a valid authenticated user is provided. - Extend component install tests to validate
UserIDselection/precedence betweenSnapState.UserIDandOptions.UserID.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
overlord/snapstate/handlers_components_download_test.go |
Adds coverage to ensure component downloads pass store user auth (macaroon) when SnapSetup.UserID is set. |
overlord/snapstate/component.go |
Propagates a resolved UserID into SnapSetup for component installation task chains. |
overlord/snapstate/component_install_test.go |
Adds tests to assert correct UserID precedence and propagation into the setup-profiles task snap-setup. |
|
Fri May 8 08:53:15 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17020 +/- ##
==========================================
- Coverage 79.06% 79.05% -0.01%
==========================================
Files 1374 1375 +1
Lines 191076 191153 +77
Branches 2465 2465
==========================================
+ Hits 151065 151120 +55
- Misses 30918 30928 +10
- Partials 9093 9105 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miguelpires
approved these changes
May 5, 2026
miguelpires
left a comment
miguelpires
left a comment
Contributor
There was a problem hiding this comment.
Thanks. This needs a rebase on master though
Mohit-Chachada
force-pushed
the
set-userid-for-download-components
branch
from
May 5, 2026 12:55
e73a4a2 to
b8d3586
Compare
Mohit-Chachada
added
the
Auto rerun spread
Contributor
Author
|
Failing Tests
These errors are not related to the changes from this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partly fixes LP2110368 where the download of a private snap's component fails. See the copilot generated overview for more details.
Based on the test results, this fixes the issue of installing components from outside the snap but does not yet resolve the issue of installing components from within the snap using snapctl. That will be then fixed in a follow-up PR.
SNAPDENG-36844